tech/sendico
2
0
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects Releases Wiki Activity

multiple payout page and small fixes #464

Merged
tech merged 2 commits from SEND047 into main 2026-02-11 15:29:28 +00:00
Conversation 2 Commits 2 Files Changed 80 +2206 -1290
protuberanets commented 2026-02-10 23:49:27 +00:00
Collaborator
Copy Link
No description provided.
protuberanets self-assigned this 2026-02-10 23:49:27 +00:00
protuberanets added 1 commit 2026-02-10 23:49:27 +00:00
multiple payout page and small fixes edb43f9909
protuberanets requested review from tech 2026-02-10 23:49:27 +00:00
tech requested changes 2026-02-11 10:56:54 +00:00
Dismissed
frontend/pshared/lib/api/responses/login_pending.dart
@@ -11,3 +11,3 @@
final AccountResponse account;
final TokenData pendingToken;
final String destination;
@JsonKey(name: 'destination')
tech commented 2026-02-11 10:56:46 +00:00
Owner
Copy Link

Поправь, пожалуйста, здесь имя переменной и атавизм в бэке на Target тоже, чтобы не расходилось.

Поправь, пожалуйста, здесь имя переменной и атавизм в бэке на Target тоже, чтобы не расходилось.
frontend/pshared/lib/provider/email_verification.dart
@@ -19,2 +16,2 @@
bool get canResendVerification =>
errorCode == 400 || errorCode == 410 || errorCode == 500;
ErrorResponse? get errorResponse =>
_resource.error is ErrorResponse ? _resource.error as ErrorResponse : null;
tech commented 2026-02-11 10:51:37 +00:00
Owner
Copy Link

есть же хелпер toException?

есть же хелпер toException?
protuberanets commented 2026-02-11 11:43:04 +00:00
Author
Collaborator
Copy Link

toException тут не помогает, он же приводит Object к Exception, но не к ErrorResponse

toException тут не помогает, он же приводит Object к Exception, но не к ErrorResponse
frontend/pshared/lib/provider/email_verification.dart Outdated
@@ -21,0 +18,4 @@
bool get canResendVerification {
final err = errorResponse;
if (err == null) return false;
switch (err.error) {
tech commented 2026-02-11 10:52:18 +00:00
Owner
Copy Link

а на код ошибки не надежнее полагаться?

а на код ошибки не надежнее полагаться?
frontend/pshared/lib/provider/payment/multiple/quotation.dart Outdated
@@ -127,3 +131,4 @@
_lastIntents = null;
_lastPreviewOnly = false;
_lastMetadata = null;
_cancelAutoRefresh();
tech commented 2026-02-11 10:53:50 +00:00
Owner
Copy Link

лучше все-таки разделить уже провайдер и контроллер. провайдер - про данные, контроллер - GUI-специфичная тема с автообновлением. А то сложно.

лучше все-таки разделить уже провайдер и контроллер. провайдер - про данные, контроллер - GUI-специфичная тема с автообновлением. А то сложно.
protuberanets added 1 commit 2026-02-11 12:26:16 +00:00
small fixes 0a1e04d0d6
tech approved these changes 2026-02-11 15:28:58 +00:00
tech merged commit 3225babeca into main 2026-02-11 15:29:28 +00:00
tech deleted branch SEND047 2026-02-11 15:29:28 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
tech
Labels
Clear labels
backend
bug
Something is not working
 cicd
Continious Integration / Continuous Deployment
 docs
duplicate
This issue or pull request already exists
 enhancement
New feature
 frontend
help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 refactoring
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
protuberanets tech
No Assignees protuberanets
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: tech/sendico#464
Delete Branch "SEND047"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?