fixed excessive logging non-nil checks)
This commit is contained in:
@@ -25,9 +25,10 @@ type Announcer struct {
|
||||
}
|
||||
|
||||
func NewAnnouncer(logger mlogger.Logger, producer msg.Producer, sender string, announce Announcement) *Announcer {
|
||||
if logger != nil {
|
||||
logger = logger.Named("discovery")
|
||||
if logger == nil {
|
||||
logger = zap.NewNop()
|
||||
}
|
||||
logger = logger.Named("discovery")
|
||||
announce = normalizeAnnouncement(announce)
|
||||
if announce.Service == "" {
|
||||
announce.Service = strings.TrimSpace(sender)
|
||||
@@ -132,14 +133,14 @@ func (a *Announcer) sendHeartbeat() {
|
||||
}
|
||||
|
||||
func (a *Announcer) logInfo(message string, fields ...zap.Field) {
|
||||
if a.logger == nil {
|
||||
if a == nil {
|
||||
return
|
||||
}
|
||||
a.logger.Info(message, fields...)
|
||||
}
|
||||
|
||||
func (a *Announcer) logWarn(message string, fields ...zap.Field) {
|
||||
if a.logger == nil {
|
||||
if a == nil {
|
||||
return
|
||||
}
|
||||
a.logger.Warn(message, fields...)
|
||||
|
||||
Reference in New Issue
Block a user