accounts creation

api/ledger/client/client.go

@@ -7,12 +7,13 @@ import (
 	"strings"
 	"time"
 
+	"github.com/tech/sendico/pkg/ledgerconv"
 	"github.com/tech/sendico/pkg/merrors"
 	"github.com/tech/sendico/pkg/payments/rail"
 	describablev1 "github.com/tech/sendico/pkg/proto/common/describable/v1"
-	connectorv1 "github.com/tech/sendico/pkg/proto/connector/v1"
 	moneyv1 "github.com/tech/sendico/pkg/proto/common/money/v1"
 	paginationv1 "github.com/tech/sendico/pkg/proto/common/pagination/v1"
+	connectorv1 "github.com/tech/sendico/pkg/proto/connector/v1"
 	ledgerv1 "github.com/tech/sendico/pkg/proto/ledger/v1"
 	"google.golang.org/grpc"
 	"google.golang.org/grpc/credentials"
@@ -192,7 +193,6 @@ func (c *ledgerClient) CreateAccount(ctx context.Context, req *ledgerv1.CreateAc
 	}
 	params := map[string]interface{}{
 		"organization_ref": strings.TrimSpace(req.GetOrganizationRef()),
-		"account_code":     strings.TrimSpace(req.GetAccountCode()),
 		"account_type":     req.GetAccountType().String(),
 		"status":           req.GetStatus().String(),
 		"allow_negative":   req.GetAllowNegative(),
@@ -523,29 +523,13 @@ func ledgerAccountFromConnector(account *connectorv1.Account) *ledgerv1.LedgerAc
 }
 
 func parseAccountType(value string) ledgerv1.AccountType {
-	switch strings.ToUpper(strings.TrimSpace(value)) {
-	case "ACCOUNT_TYPE_ASSET", "ASSET":
-		return ledgerv1.AccountType_ACCOUNT_TYPE_ASSET
-	case "ACCOUNT_TYPE_LIABILITY", "LIABILITY":
-		return ledgerv1.AccountType_ACCOUNT_TYPE_LIABILITY
-	case "ACCOUNT_TYPE_REVENUE", "REVENUE":
-		return ledgerv1.AccountType_ACCOUNT_TYPE_REVENUE
-	case "ACCOUNT_TYPE_EXPENSE", "EXPENSE":
-		return ledgerv1.AccountType_ACCOUNT_TYPE_EXPENSE
-	default:
-		return ledgerv1.AccountType_ACCOUNT_TYPE_UNSPECIFIED
-	}
+	accountType, _ := ledgerconv.ParseAccountType(value)
+	return accountType
 }
 
 func parseAccountStatus(value string) ledgerv1.AccountStatus {
-	switch strings.ToUpper(strings.TrimSpace(value)) {
-	case "ACCOUNT_STATUS_ACTIVE", "ACTIVE":
-		return ledgerv1.AccountStatus_ACCOUNT_STATUS_ACTIVE
-	case "ACCOUNT_STATUS_FROZEN", "FROZEN":
-		return ledgerv1.AccountStatus_ACCOUNT_STATUS_FROZEN
-	default:
-		return ledgerv1.AccountStatus_ACCOUNT_STATUS_UNSPECIFIED
-	}
+	status, _ := ledgerconv.ParseAccountStatus(value)
+	return status
 }
 
 func journalEntryFromOperation(op *connectorv1.Operation) *ledgerv1.JournalEntryResponse {
@@ -553,11 +537,11 @@ func journalEntryFromOperation(op *connectorv1.Operation) *ledgerv1.JournalEntry
 		return nil
 	}
 	entry := &ledgerv1.JournalEntryResponse{
-		EntryRef:     strings.TrimSpace(op.GetOperationId()),
-		EntryType:    entryTypeFromOperation(op.GetType()),
-		Description:  operationDescription(op),
-		EventTime:    op.GetCreatedAt(),
-		Lines:        postingLinesFromOperation(op),
+		EntryRef:          strings.TrimSpace(op.GetOperationId()),
+		EntryType:         entryTypeFromOperation(op.GetType()),
+		Description:       operationDescription(op),
+		EventTime:         op.GetCreatedAt(),
+		Lines:             postingLinesFromOperation(op),
 		LedgerAccountRefs: ledgerAccountRefsFromOperation(op),
 	}
 	return entry