tech/sendico
2
0
Fork 0
Code Issues 31 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

ledger accounts improvement

Browse Source
This commit is contained in:
Stephan D
2026-01-30 15:54:45 +01:00
parent 51f5b0804a
commit 17dde423f6
40 changed files with 3355 additions and 570 deletions
Download Patch File Download Diff File Expand all files Collapse all files

210
api/ledger/storage/mongo/store/accounts_test.go
View File

@@ -5,15 +5,15 @@ import (
"errors"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/tech/sendico/ledger/storage"
"github.com/tech/sendico/ledger/storage/model"
"github.com/tech/sendico/pkg/db/repository"
"github.com/tech/sendico/pkg/db/repository/builder"
rd "github.com/tech/sendico/pkg/db/repository/decoder"
"github.com/tech/sendico/pkg/db/storable"
"github.com/tech/sendico/pkg/merrors"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
pkm "github.com/tech/sendico/pkg/model"
"go.mongodb.org/mongo-driver/bson/primitive"
"go.mongodb.org/mongo-driver/mongo"
"go.uber.org/zap"
@@ -24,20 +24,20 @@ func TestAccountsStore_Create(t *testing.T) {
logger := zap.NewNop()
t.Run("Success", func(t *testing.T) {
var insertedAccount *model.Account
var insertedAccount *pkm.LedgerAccount
stub := &repositoryStub{
InsertFunc: func(ctx context.Context, object storable.Storable, _ builder.Query) error {
insertedAccount = object.(*model.Account)
insertedAccount = object.(*pkm.LedgerAccount)
return nil
},
}
store := &accountsStore{logger: logger, repo: stub}
account := &model.Account{
account := &pkm.LedgerAccount{
AccountCode: "1000",
Currency: "USD",
AccountType: model.AccountTypeAsset,
Status: model.AccountStatusActive,
AccountType: pkm.LedgerAccountTypeAsset,
Status: pkm.LedgerAccountStatusActive,
AllowNegative: false,
}
@@ -71,7 +71,7 @@ func TestAccountsStore_Create(t *testing.T) {
}
store := &accountsStore{logger: logger, repo: stub}
account := &model.Account{
account := &pkm.LedgerAccount{
AccountCode: "1000",
Currency: "USD",
}
@@ -91,7 +91,7 @@ func TestAccountsStore_Create(t *testing.T) {
}
store := &accountsStore{logger: logger, repo: stub}
account := &model.Account{AccountCode: "1000", Currency: "USD"}
account := &pkm.LedgerAccount{AccountCode: "1000", Currency: "USD"}
err := store.Create(ctx, account)
@@ -108,7 +108,7 @@ func TestAccountsStore_Get(t *testing.T) {
accountRef := primitive.NewObjectID()
stub := &repositoryStub{
GetFunc: func(ctx context.Context, id primitive.ObjectID, result storable.Storable) error {
account := result.(*model.Account)
account := result.(*pkm.LedgerAccount)
account.SetID(accountRef)
account.AccountCode = "1000"
account.Currency = "USD"
@@ -178,7 +178,7 @@ func TestAccountsStore_GetByAccountCode(t *testing.T) {
t.Run("Success", func(t *testing.T) {
stub := &repositoryStub{
FindOneByFilterFunc: func(ctx context.Context, _ builder.Query, result storable.Storable) error {
account := result.(*model.Account)
account := result.(*pkm.LedgerAccount)
account.AccountCode = "1000"
account.Currency = "USD"
return nil
@@ -243,6 +243,89 @@ func TestAccountsStore_GetByAccountCode(t *testing.T) {
})
}
func TestAccountsStore_GetByRole(t *testing.T) {
ctx := context.Background()
logger := zap.NewNop()
orgRef := primitive.NewObjectID()
t.Run("Success", func(t *testing.T) {
stub := &repositoryStub{
FindOneByFilterFunc: func(ctx context.Context, _ builder.Query, result storable.Storable) error {
account := result.(*pkm.LedgerAccount)
account.Currency = "USD"
account.Role = pkm.AccountRoleOperating
return nil
},
}
store := &accountsStore{logger: logger, repo: stub}
result, err := store.GetByRole(ctx, orgRef, "USD", pkm.AccountRoleOperating)
require.NoError(t, err)
assert.NotNil(t, result)
assert.Equal(t, pkm.AccountRoleOperating, result.Role)
assert.Equal(t, "USD", result.Currency)
})
t.Run("ZeroOrganizationID", func(t *testing.T) {
store := &accountsStore{logger: logger, repo: &repositoryStub{}}
result, err := store.GetByRole(ctx, primitive.NilObjectID, "USD", pkm.AccountRoleOperating)
require.Error(t, err)
assert.Nil(t, result)
assert.True(t, errors.Is(err, merrors.ErrInvalidArg))
})
t.Run("EmptyCurrency", func(t *testing.T) {
store := &accountsStore{logger: logger, repo: &repositoryStub{}}
result, err := store.GetByRole(ctx, orgRef, "", pkm.AccountRoleOperating)
require.Error(t, err)
assert.Nil(t, result)
assert.True(t, errors.Is(err, merrors.ErrInvalidArg))
})
t.Run("EmptyRole", func(t *testing.T) {
store := &accountsStore{logger: logger, repo: &repositoryStub{}}
result, err := store.GetByRole(ctx, orgRef, "USD", "")
require.Error(t, err)
assert.Nil(t, result)
assert.True(t, errors.Is(err, merrors.ErrInvalidArg))
})
t.Run("NotFound", func(t *testing.T) {
stub := &repositoryStub{
FindOneByFilterFunc: func(ctx context.Context, _ builder.Query, result storable.Storable) error {
return merrors.ErrNoData
},
}
store := &accountsStore{logger: logger, repo: stub}
result, err := store.GetByRole(ctx, orgRef, "USD", pkm.AccountRoleOperating)
require.Error(t, err)
assert.Nil(t, result)
assert.True(t, errors.Is(err, storage.ErrAccountNotFound))
})
t.Run("FindError", func(t *testing.T) {
expectedErr := errors.New("database error")
stub := &repositoryStub{
FindOneByFilterFunc: func(ctx context.Context, _ builder.Query, result storable.Storable) error {
return expectedErr
},
}
store := &accountsStore{logger: logger, repo: stub}
result, err := store.GetByRole(ctx, orgRef, "USD", pkm.AccountRoleOperating)
require.Error(t, err)
assert.Nil(t, result)
assert.Equal(t, expectedErr, err)
})
}
func TestAccountsStore_GetDefaultSettlement(t *testing.T) {
ctx := context.Background()
logger := zap.NewNop()
@@ -251,10 +334,10 @@ func TestAccountsStore_GetDefaultSettlement(t *testing.T) {
t.Run("Success", func(t *testing.T) {
stub := &repositoryStub{
FindOneByFilterFunc: func(ctx context.Context, _ builder.Query, result storable.Storable) error {
account := result.(*model.Account)
account := result.(*pkm.LedgerAccount)
account.SetID(primitive.NewObjectID())
account.Currency = "USD"
account.IsSettlement = true
account.Role = pkm.AccountRoleSettlement
return nil
},
}
@@ -264,7 +347,7 @@ func TestAccountsStore_GetDefaultSettlement(t *testing.T) {
require.NoError(t, err)
assert.NotNil(t, result)
assert.True(t, result.IsSettlement)
assert.Equal(t, pkm.AccountRoleSettlement, result.Role)
assert.Equal(t, "USD", result.Currency)
})
@@ -318,6 +401,83 @@ func TestAccountsStore_GetDefaultSettlement(t *testing.T) {
})
}
func TestAccountsStore_GetSystemAccount(t *testing.T) {
ctx := context.Background()
logger := zap.NewNop()
t.Run("Success", func(t *testing.T) {
stub := &repositoryStub{
FindOneByFilterFunc: func(ctx context.Context, _ builder.Query, result storable.Storable) error {
account := result.(*pkm.LedgerAccount)
account.Currency = "USD"
purpose := pkm.SystemAccountPurposeExternalSource
account.SystemPurpose = &purpose
account.Scope = pkm.LedgerAccountScopeSystem
return nil
},
}
store := &accountsStore{logger: logger, repo: stub}
result, err := store.GetSystemAccount(ctx, pkm.SystemAccountPurposeExternalSource, "USD")
require.NoError(t, err)
require.NotNil(t, result)
require.Equal(t, pkm.LedgerAccountScopeSystem, result.Scope)
require.NotNil(t, result.SystemPurpose)
require.Equal(t, pkm.SystemAccountPurposeExternalSource, *result.SystemPurpose)
require.Equal(t, "USD", result.Currency)
})
t.Run("EmptyPurpose", func(t *testing.T) {
store := &accountsStore{logger: logger, repo: &repositoryStub{}}
result, err := store.GetSystemAccount(ctx, "", "USD")
require.Error(t, err)
require.Nil(t, result)
require.True(t, errors.Is(err, merrors.ErrInvalidArg))
})
t.Run("EmptyCurrency", func(t *testing.T) {
store := &accountsStore{logger: logger, repo: &repositoryStub{}}
result, err := store.GetSystemAccount(ctx, pkm.SystemAccountPurposeExternalSink, "")
require.Error(t, err)
require.Nil(t, result)
require.True(t, errors.Is(err, merrors.ErrInvalidArg))
})
t.Run("NotFound", func(t *testing.T) {
stub := &repositoryStub{
FindOneByFilterFunc: func(ctx context.Context, _ builder.Query, result storable.Storable) error {
return merrors.ErrNoData
},
}
store := &accountsStore{logger: logger, repo: stub}
result, err := store.GetSystemAccount(ctx, pkm.SystemAccountPurposeExternalSource, "USD")
require.Error(t, err)
require.Nil(t, result)
require.True(t, errors.Is(err, storage.ErrAccountNotFound))
})
t.Run("FindError", func(t *testing.T) {
expectedErr := errors.New("database error")
stub := &repositoryStub{
FindOneByFilterFunc: func(ctx context.Context, _ builder.Query, result storable.Storable) error {
return expectedErr
},
}
store := &accountsStore{logger: logger, repo: stub}
result, err := store.GetSystemAccount(ctx, pkm.SystemAccountPurposeExternalSource, "USD")
require.Error(t, err)
require.Nil(t, result)
require.Equal(t, expectedErr, err)
})
}
func TestAccountsStore_ListByOrganization(t *testing.T) {
ctx := context.Background()
logger := zap.NewNop()
@@ -335,7 +495,7 @@ func TestAccountsStore_ListByOrganization(t *testing.T) {
}
store := &accountsStore{logger: logger, repo: stub}
results, err := store.ListByOrganization(ctx, orgRef, 10, 0)
results, err := store.ListByOrganization(ctx, orgRef, nil, 10, 0)
require.NoError(t, err)
assert.True(t, calledWithQuery, "FindManyByFilter should have been called")
@@ -346,7 +506,7 @@ func TestAccountsStore_ListByOrganization(t *testing.T) {
stub := &repositoryStub{}
store := &accountsStore{logger: logger, repo: stub}
results, err := store.ListByOrganization(ctx, primitive.NilObjectID, 10, 0)
results, err := store.ListByOrganization(ctx, primitive.NilObjectID, nil, 10, 0)
require.Error(t, err)
assert.Nil(t, results)
@@ -361,7 +521,7 @@ func TestAccountsStore_ListByOrganization(t *testing.T) {
}
store := &accountsStore{logger: logger, repo: stub}
results, err := store.ListByOrganization(ctx, orgRef, 10, 0)
results, err := store.ListByOrganization(ctx, orgRef, nil, 10, 0)
require.NoError(t, err)
assert.Len(t, results, 0)
@@ -376,7 +536,7 @@ func TestAccountsStore_ListByOrganization(t *testing.T) {
}
store := &accountsStore{logger: logger, repo: stub}
results, err := store.ListByOrganization(ctx, orgRef, 10, 0)
results, err := store.ListByOrganization(ctx, orgRef, nil, 10, 0)
require.Error(t, err)
assert.Nil(t, results)
@@ -391,29 +551,29 @@ func TestAccountsStore_UpdateStatus(t *testing.T) {
t.Run("Success", func(t *testing.T) {
var patchedID primitive.ObjectID
var patchedStatus model.AccountStatus
var patchedStatus pkm.LedgerAccountStatus
stub := &repositoryStub{
PatchFunc: func(ctx context.Context, id primitive.ObjectID, _ repository.PatchDoc) error {
patchedID = id
// In real test, we'd inspect patch builder but this is sufficient for stub
patchedStatus = model.AccountStatusFrozen
patchedStatus = pkm.LedgerAccountStatusFrozen
return nil
},
}
store := &accountsStore{logger: logger, repo: stub}
err := store.UpdateStatus(ctx, accountRef, model.AccountStatusFrozen)
err := store.UpdateStatus(ctx, accountRef, pkm.LedgerAccountStatusFrozen)
require.NoError(t, err)
assert.Equal(t, accountRef, patchedID)
assert.Equal(t, model.AccountStatusFrozen, patchedStatus)
assert.Equal(t, pkm.LedgerAccountStatusFrozen, patchedStatus)
})
t.Run("ZeroID", func(t *testing.T) {
stub := &repositoryStub{}
store := &accountsStore{logger: logger, repo: stub}
err := store.UpdateStatus(ctx, primitive.NilObjectID, model.AccountStatusFrozen)
err := store.UpdateStatus(ctx, primitive.NilObjectID, pkm.LedgerAccountStatusFrozen)
require.Error(t, err)
assert.True(t, errors.Is(err, merrors.ErrInvalidArg))
@@ -428,7 +588,7 @@ func TestAccountsStore_UpdateStatus(t *testing.T) {
}
store := &accountsStore{logger: logger, repo: stub}
err := store.UpdateStatus(ctx, accountRef, model.AccountStatusFrozen)
err := store.UpdateStatus(ctx, accountRef, pkm.LedgerAccountStatusFrozen)
require.Error(t, err)
assert.Equal(t, expectedErr, err)