refactored orchestrator and callbacks service to use pkg messsaging + envelope factory / handler

api/edge/callbacks/internal/server/internal/serverimp.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"time"
 
-	"github.com/nats-io/nats.go"
 	"github.com/tech/sendico/edge/callbacks/internal/config"
 	"github.com/tech/sendico/edge/callbacks/internal/delivery"
 	"github.com/tech/sendico/edge/callbacks/internal/events"
@@ -18,7 +17,6 @@ import (
 	"github.com/tech/sendico/edge/callbacks/internal/subscriptions"
 	"github.com/tech/sendico/pkg/api/routers/health"
 	"github.com/tech/sendico/pkg/db"
-	"github.com/tech/sendico/pkg/merrors"
 	msg "github.com/tech/sendico/pkg/messaging"
 	"github.com/tech/sendico/pkg/mlogger"
 	"github.com/tech/sendico/pkg/vault/kv"
@@ -27,10 +25,6 @@ import (
 
 const defaultShutdownTimeout = 15 * time.Second
 
-type jetStreamProvider interface {
-	JetStream() nats.JetStreamContext
-}
-
 func Create(logger mlogger.Logger, file string, debug bool) (*Imp, error) {
 	return &Imp{
 		logger: logger.Named("server"),
@@ -118,23 +112,9 @@ func (i *Imp) Start() error {
 	}
 	i.broker = broker
 
-	jsProvider, ok := broker.(jetStreamProvider)
-	if !ok || jsProvider.JetStream() == nil {
-		i.shutdownRuntime(context.Background())
-		return merrors.Internal("callbacks: messaging broker does not provide JetStream")
-	}
-
 	ingestSvc, err := ingest.New(ingest.Dependencies{
-		Logger:    i.logger,
-		JetStream: jsProvider.JetStream(),
-		Config: ingest.Config{
-			Stream:       cfg.Ingest.Stream,
-			Subject:      cfg.Ingest.Subject,
-			Durable:      cfg.Ingest.Durable,
-			BatchSize:    cfg.Ingest.BatchSize,
-			FetchTimeout: cfg.Ingest.FetchTimeout(),
-			IdleSleep:    cfg.Ingest.IdleSleep(),
-		},
+		Logger:       i.logger,
+		Broker:       broker,
 		Events:       eventSvc,
 		Resolver:     resolver,
 		InboxRepo:    repo.Inbox(),
@@ -176,8 +156,6 @@ func (i *Imp) Start() error {
 	i.opServer.SetStatus(health.SSRunning)
 
 	i.logger.Info("Callbacks service ready",
-		zap.String("subject", cfg.Ingest.Subject),
-		zap.String("stream", cfg.Ingest.Stream),
 		zap.Int("workers", cfg.Delivery.WorkerConcurrency),
 	)